Fix nodes coordinator registry save #3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #3504 +/- ##
============================================
Coverage 73.87% 73.88%
============================================
Files 582 582
Lines 74532 74545 +13
============================================
+ Hits 55064 55075 +11
- Misses 15065 15066 +1
- Partials 4403 4404 +1
Continue to review full report at Codecov.
|
raduchis
previously approved these changes
Oct 12, 2021
|
|
||
| // LoadState loads the nodes coordinator state from the used boot storage | ||
| func (ihgs *indexHashedNodesCoordinatorWithRater) LoadState(key []byte) error { | ||
| return ihgs.baseLoadState(key) |
There was a problem hiding this comment.
👍 for the move to the appropriate file
| } | ||
|
|
||
| for epoch, epochNodesData := range ihgs.nodesConfig { | ||
| minEpoch := 0 | ||
| if ihgs.currentEpoch >= nodeCoordinatorStoredEpochs { |
There was a problem hiding this comment.
is there a typo here? I think nodesCoordinatorStoredEpochs sounds better.
There was a problem hiding this comment.
Also, for performance reasons I would have put it in reverse, like:
minEpoch = int(ihgs.currentEpoch) - nodeCoordinatorStoredEpochs + 1
if minEpoch < 0{
minEpoch = 0
}as for the current state (epoch 400+) the node will always execute the if branch
iulianpascalau
approved these changes
Oct 12, 2021
iulianpascalau
previously approved these changes
Oct 12, 2021
…lrondNetwork/elrond-go into fix-nodes-coordinator-registry-pruning
AdoAdoAdo
dismissed stale reviews from iulianpascalau and raduchis
via
1cd21e8
iulianpascalau
approved these changes
Oct 14, 2021
raduchis
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there is a restart in every epoch, the registry for nodes coordinator does not get pruned.
This PR ensures that every nodes coordinator registry save is done only for the configured number of epochs.