delete delegator on claim rewards if needed #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #3509 +/- ##
============================================
Coverage 73.88% 73.88%
============================================
Files 582 582
Lines 74549 74579 +30
============================================
+ Hits 55077 55105 +28
- Misses 15069 15071 +2
Partials 4403 4403
Continue to review full report at Codecov.
|
iulianpascalau
previously approved these changes
Oct 14, 2021
sasurobert
reviewed
Oct 14, 2021
cmd/node/config/enableEpochs.toml
Outdated
| @@ -135,6 +135,9 @@ | |||
| # CorrectFirstQueuedEpoch represents the epoch when the backward compatibility for setting the first queued node is enabled | |||
| CorrectFirstQueuedEpoch = 5 | |||
|
|
|||
| # DeleteDelegatorAfterClaimRewardsEnableEpoch represents the epoch when the delegators data is deleted for delegators that have to claim rewards after they widrawal all funds | |||
| DeleteDelegatorAfterClaimRewardsEnableEpoch = 1000000 | |||
iulianpascalau
previously approved these changes
Oct 14, 2021
sasurobert
previously approved these changes
Oct 14, 2021
miiu96
dismissed stale reviews from sasurobert and iulianpascalau
via
4dbe1eb
cmd/node/config/enableEpochs.toml
Outdated
| @@ -133,10 +133,10 @@ | |||
| OptimizeGasUsedInCrossMiniBlocksEnableEpoch = 2 | |||
|
|
|||
| # CorrectFirstQueuedEpoch represents the epoch when the backward compatibility for setting the first queued node is enabled | |||
| CorrectFirstQueuedEpoch = 6 | |||
| CorrectFirstQueuedEpoch = 5 | |||
There was a problem hiding this comment.
as these 2 will probably be set altogether, why not setting CorrectFirstQueuedEpoch and DeleteDelegatorAfterClaimRewardsEnableEpoch to 2?
iulianpascalau
previously approved these changes
Oct 14, 2021
sasurobert
previously approved these changes
Oct 14, 2021
# Conflicts: # config/epochConfig.go # node/nodeRunner.go
miiu96
dismissed stale reviews from sasurobert and iulianpascalau
via
1f7ba9a
iulianpascalau
previously approved these changes
Oct 15, 2021
sasurobert
previously approved these changes
Oct 15, 2021
miiu96
dismissed stale reviews from gabi-vuls, sasurobert, and iulianpascalau
via
080bbda
LucianMincu
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
Re-approved on system tests as only integration tests changed since latest review from @gabi-vuls.
iulianpascalau
approved these changes
Oct 15, 2021
sasurobert
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug-fix: Fixed the situation when a delegator withdraws all his funds but the rewards remain. In this situation,
delegatorDatais not deleted because this user still has some rewards to claim.Now we have a check that will delete
delegatorDataalso on theclaimRewardsfunction if needed.logLogfortransferOwnershipfunction.