Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid checking gas limit in sender shard by receiver shard #3512

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Avoid checking gas limit in sender shard by receiver shard #3512

merged 2 commits into from
Oct 15, 2021

Conversation

SebastianMarian
Copy link
Contributor

  • Fix checking gas consumed in sender shard by receiver shard

@SebastianMarian SebastianMarian added the type:bug Something isn't working label Oct 15, 2021
@SebastianMarian SebastianMarian self-assigned this Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021 •
edited

Codecov Report

Merging #3512 (709f739) into development (7a7419e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #3512   +/-   ##
============================================
  Coverage        73.87%   73.88%           
============================================
  Files              582      582           
  Lines            74551    74549    -2     
============================================
  Hits             55077    55077           
+ Misses           15070    15069    -1     
+ Partials          4404     4403    -1
Impacted Files Coverage Δ
process/block/preprocess/basePreProcess.go 77.77% <ø> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 955a08b...709f739. Read the comment docs.

gabi-vuls
gabi-vuls approved these changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.
image

@LucianMincu LucianMincu merged commit bf1474c into development Oct 15, 2021
@LucianMincu LucianMincu deleted the avoid-checking-gas-limit-in-sender-shard-from-receiver branch October 15, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurobert sasurobert sasurobert approved these changes

@iulianpascalau iulianpascalau iulianpascalau approved these changes

@gabi-vuls gabi-vuls gabi-vuls approved these changes

Assignees

@SebastianMarian SebastianMarian

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SebastianMarian @sasurobert @iulianpascalau @gabi-vuls @LucianMincu