Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arwen 1.4.23 #3513

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Arwen 1.4.23 #3513

merged 3 commits into from
Oct 15, 2021

Conversation

sasurobert
Copy link
Contributor

added flags, integrated new arwen

go.mod Outdated
@@ -55,4 +55,4 @@ replace github.com/ElrondNetwork/arwen-wasm-vm/v1_2 v1.2.30 => github.com/Elrond

replace github.com/ElrondNetwork/arwen-wasm-vm/v1_3 v1.3.30 => github.com/ElrondNetwork/arwen-wasm-vm v1.3.30

replace github.com/ElrondNetwork/arwen-wasm-vm/v1_4 v1.4.19 => github.com/ElrondNetwork/arwen-wasm-vm v1.4.19
replace github.com/ElrondNetwork/arwen-wasm-vm/v1_4 v1.4.19 => github.com/ElrondNetwork/arwen-wasm-vm v1.4.22-0.20211015092013-850bb00d4896
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not forget the proper release here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -303,6 +303,8 @@ func (vmf *vmContainerFactory) createInProcessArwenVMV14() (vmcommon.VMExecution
ESDTTransferParser: vmf.esdtTransferParser,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alignment went wrong here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #3513 (7a7419e) into development (9d65912) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3513      +/-   ##
===============================================
- Coverage        73.88%   73.87%   -0.01%     
===============================================
  Files              582      582              
  Lines            74545    74551       +6     
===============================================
+ Hits             55075    55077       +2     
- Misses           15066    15070       +4     
  Partials          4404     4404              
Impacted Files Coverage Δ
genesis/process/shardGenesisBlockCreator.go 42.91% <0.00%> (-0.19%) ⬇️
node/nodeRunner.go 0.00% <0.00%> (ø)
process/factory/shard/vmContainerFactory.go 75.86% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e958ed3...7a7419e. Read the comment docs.

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.
image

@@ -677,6 +683,8 @@ func TestEnableEpochConfig(t *testing.T) {
AddTokensToDelegationEnableEpoch: 41,
MultiESDTTransferFixOnCallBackOnEnableEpoch: 42,
OptimizeGasUsedInCrossMiniBlocksEnableEpoch: 43,
FixOOGReturnCodeEnableEpoch: 44,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

48

@@ -677,6 +683,8 @@ func TestEnableEpochConfig(t *testing.T) {
AddTokensToDelegationEnableEpoch: 41,
MultiESDTTransferFixOnCallBackOnEnableEpoch: 42,
OptimizeGasUsedInCrossMiniBlocksEnableEpoch: 43,
FixOOGReturnCodeEnableEpoch: 44,
RemoveNonUpdatedStorageEnableEpoch: 45,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

49

@@ -607,6 +607,12 @@ func TestEnableEpochConfig(t *testing.T) {
# OptimizeGasUsedInCrossMiniBlocksEnableEpoch represents the epoch when gas used in cross shard mini blocks will be optimized
OptimizeGasUsedInCrossMiniBlocksEnableEpoch = 43

# FixOOGReturnCodeEnableEpoch represents the epoch when the backward compatibility returning out of gas error is enabled
FixOOGReturnCodeEnableEpoch = 44
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

48

FixOOGReturnCodeEnableEpoch = 44

# RemoveNonUpdatedStorageEnableEpoch represents the epoch when the backward compatibility for removing non updated storage is enabled
RemoveNonUpdatedStorageEnableEpoch = 45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

49

@LucianMincu LucianMincu merged commit 955a08b into development Oct 15, 2021
@LucianMincu LucianMincu deleted the arwen-1-4-23 branch October 15, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants