return when writing under protected key #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianpascalau
previously approved these changes
Oct 19, 2021
bogdan-rosianu
requested changes
Oct 19, 2021
bogdan-rosianu
approved these changes
Oct 19, 2021
| @@ -225,6 +227,7 @@ func NewSmartContractProcessor(args ArgsNewSmartContractProcessor) (*scProcessor | |||
| incrementSCRNonceInMultiTransferEnableEpoch: args.EnableEpochs.IncrementSCRNonceInMultiTransferEnableEpoch, | |||
| createdCallBackCrossShardOnlyEnableEpoch: args.EnableEpochs.MultiESDTTransferFixOnCallBackOnEnableEpoch, | |||
| optimizeGasUsedInCrossMiniBlocksEnableEpoch: args.EnableEpochs.OptimizeGasUsedInCrossMiniBlocksEnableEpoch, | |||
| saveKeyValueUnderProtectedErrorEnableEpoch: args.EnableEpochs.RemoveNonUpdatedStorageEnableEpoch, | |||
There was a problem hiding this comment.
Will be used flag RemoveNonUpdatedStorageEnableEpoch for saveKeyValueUnderProtectedErrorEnableEpoch ?
There was a problem hiding this comment.
as discussed, it is wise to use them together. By using 2 different flags with different values we might get into some problems -> correctly executed transactions might get rejected.
Codecov Report
@@ Coverage Diff @@
## master #3520 +/- ##
==========================================
- Coverage 73.88% 73.88% -0.01%
==========================================
Files 582 582
Lines 74579 74585 +6
==========================================
+ Hits 55105 55109 +4
- Misses 15071 15073 +2
Partials 4403 4403
Continue to review full report at Codecov.
|
SebastianMarian
approved these changes
Oct 19, 2021
iulianpascalau
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added return if error when writing under protected key