Tx simulator fix #3530
Tx simulator fix #3530
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3530 +/- ##
==========================================
- Coverage 73.88% 73.87% -0.02%
==========================================
Files 582 582
Lines 74585 74618 +33
==========================================
+ Hits 55108 55122 +14
- Misses 15073 15086 +13
- Partials 4404 4410 +6
Continue to review full report at Codecov.
|
| @@ -189,6 +189,20 @@ | |||
| MaxBatchSize = 100 | |||
| MaxOpenFiles = 10 | |||
|
|
|||
| [SmartContractsStorageSimulate] | |||
There was a problem hiding this comment.
SmartContractsStorageMock or SmartContractsStorageForTxSimulator instead SmartContractsStorageSimulate to each name here ?
| @@ -124,6 +124,7 @@ type Config struct { | |||
| SmartContractsStorage StorageConfig | |||
| SmartContractsStorageForSCQuery StorageConfig | |||
| TrieEpochRootHashStorage StorageConfig | |||
| SmartContractsStorageSimulate StorageConfig | |||
There was a problem hiding this comment.
SmartContractsStorageMock or SmartContractsStorageForTxSimulator instead SmartContractsStorageSimulate to each name here ?
| @@ -33,7 +33,7 @@ func Test_newBlockProcessorCreatorForShard(t *testing.T) { | |||
| _, err := pcf.Create() | |||
| require.NoError(t, err) | |||
|
|
|||
| bp, err := pcf.NewBlockProcessor( | |||
| bp, vmFactoryForSimulate, err := pcf.NewBlockProcessor( | |||
There was a problem hiding this comment.
vmFactoryMock or vmFactoryForTxSimulator ?
| @@ -136,7 +137,7 @@ func Test_newBlockProcessorCreatorForMeta(t *testing.T) { | |||
| _, err = pcf.Create() | |||
| require.NoError(t, err) | |||
|
|
|||
| bp, err := pcf.NewBlockProcessor( | |||
| bp, vmFactoryForSimulate, err := pcf.NewBlockProcessor( | |||
There was a problem hiding this comment.
vmFactoryMock or vmFactoryForTxSimulator ?
| SmartContractsStorageSimulate: config.StorageConfig{ | ||
| Cache: getLRUCacheConfig(), | ||
| DB: config.DBConfig{ | ||
| FilePath: AddTimestampSuffix("SmartContractsStorageSimulate"), |
There was a problem hiding this comment.
SmartContractsStorageMock or SmartContractsStorageForTxSimulator instead SmartContractsStorageSimulate ?
| } | ||
|
|
||
| smartContractStorageSimulate := pcf.config.SmartContractsStorageSimulate |
There was a problem hiding this comment.
SmartContractsStorageMock or SmartContractsStorageForTxSimulator instead SmartContractsStorageSimulate ?
| @@ -189,6 +189,20 @@ | |||
| MaxBatchSize = 100 | |||
| MaxOpenFiles = 10 | |||
|
|
|||
| [SmartContractsStorageSimulate] | |||
| adb.stackDebug = debug.Stack() | ||
| } | ||
| } | ||
|
|
| @@ -962,6 +965,17 @@ func (adb *AccountsDB) journalize(entry JournalEntry) { | |||
|
|
|||
| adb.entries = append(adb.entries, entry) | |||
| log.Trace("accountsDB.Journalize", "new length", len(adb.entries)) | |||
|
|
|||
| if len(adb.entries) == 1 { | |||
There was a problem hiding this comment.
@iulianpascalau can you answer this ?
|
System test results v1.2.22-dev-config to fix-boot-from-storage-after-import Known ERRORS 77 Passed |
Bug-fixes on transaction simulator.