storage, factory: fix bootstrap from storage after import #3531
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3531 +/- ##
=======================================
Coverage 73.87% 73.88%
=======================================
Files 582 581 -1
Lines 74618 74583 -35
=======================================
- Hits 55122 55102 -20
+ Misses 15086 15077 -9
+ Partials 4410 4404 -6
Continue to review full report at Codecov.
|
| @@ -61,29 +61,54 @@ func NewLatestDataProvider(args ArgsLatestDataProvider) (*latestDataProvider, er | |||
| }, nil | |||
| } | |||
|
|
|||
| // Get will return a struct containing the latest data in storage | |||
| // Get will return a struct containing the latest usable data for the full archive node in storage | |||
There was a problem hiding this comment.
not necessary for the full archive right now
| } | ||
|
|
||
| // GetParentDirAndLastEpoch returns the parent directory and last epoch | ||
| // GetParentDirAndLastEpoch returns the parent directory and last usable epoch for the full archive node |
There was a problem hiding this comment.
not necessary for the full archive
| lastEpoch, err := ldp.GetLastEpochFromDirNames(epochDirs, 0) | ||
| if err != nil { | ||
| return "", 0, err | ||
| for index := range epochDirs { |
There was a problem hiding this comment.
a lot of duplicated code with L71. Can be one function that returns the parentDir, lastEpoch, latestDataFromStorage, err
…dNetwork/elrond-go into fix-boot-from-storage-after-import
AdoAdoAdo
dismissed stale reviews from raduchis and SebastianMarian
via
e614101
| return parentDir, lastEpoch, err | ||
| } | ||
|
|
||
| func (ldp *latestDataProvider) getLastData() (storage.LatestDataFromStorage, string, uint32, error) { |
When startInEpoch is disabled, instead of failing immediately the bootstrap from storage if the last epoch db does not have the bootstrap data, try to use the previous epoch DB and go from there.