Pruning storer fixes #3562
Merged
Pruning storer fixes #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Nov 5, 2021
iulianpascalau
commented
- fixed concurrent persisters opening
- fixed a leaking pointer on an opened persister
- fixed a leaking pointer on an opened persister
AdoAdoAdo
reviewed
Nov 5, 2021
| } | ||
|
|
||
| p.setPersisterAndIsClosed(db, false) |
There was a problem hiding this comment.
The method name is confusing
AdoAdoAdo
approved these changes
Nov 5, 2021
Codecov Report
@@ Coverage Diff @@
## development #3562 +/- ##
===============================================
- Coverage 73.90% 73.90% -0.01%
===============================================
Files 581 581
Lines 74680 74682 +2
===============================================
Hits 55193 55193
- Misses 15078 15079 +1
- Partials 4409 4410 +1
Continue to review full report at Codecov.
|
SebastianMarian
approved these changes
Nov 5, 2021
| } | ||
|
|
||
| p.setPersisterAndIsClosed(db, false) |
There was a problem hiding this comment.
The method name is confusing
👍 good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.