Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trie sync fixes & optimizations #3588

Merged
merged 4 commits into from
Nov 17, 2021
Merged

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented Nov 13, 2021

  • optimized trie nodes loading when searching in the missing hashes map
  • added more info in the trie sync prints
  • added data tries statistics when syncing the state

@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #3588 (1bd72fc) into development (2aa7a26) will increase coverage by 0.02%.
The diff coverage is 84.16%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3588      +/-   ##
===============================================
+ Coverage        73.95%   73.97%   +0.02%     
===============================================
  Files              581      582       +1     
  Lines            74794    74866      +72     
===============================================
+ Hits             55311    55381      +70     
  Misses           15075    15075              
- Partials          4408     4410       +2     
Impacted Files Coverage Δ
trie/syncCreator.go 100.00% <ø> (ø)
factory/dataComponents.go 75.00% <50.00%> (-1.09%) ⬇️
epochStart/bootstrap/process.go 54.48% <63.63%> (+0.17%) ⬆️
trie/doubleListSync.go 88.13% <68.00%> (-1.97%) ⬇️
dataRetriever/factory/dataPoolFactory.go 95.18% <80.00%> (+10.23%) ⬆️
trie/sync.go 75.51% <88.23%> (+0.37%) ⬆️
dataRetriever/dataPool/currentBlockPool.go 100.00% <100.00%> (ø)
epochStart/metachain/baseRewards.go 94.23% <100.00%> (+0.71%) ⬆️
factory/consensusComponents.go 83.13% <100.00%> (+0.04%) ⬆️
...orage/storageCacherAdapter/storageCacherAdapter.go 80.41% <100.00%> (+1.47%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0d7c2...1bd72fc. Read the comment docs.

@iulianpascalau iulianpascalau marked this pull request as ready for review November 14, 2021 23:04
@sasurobert sasurobert self-requested a review November 15, 2021 07:48
sasurobert
sasurobert previously approved these changes Nov 15, 2021
- removed unnecessary double log prints
- made the close trie nodes cacher not panic the node
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.
image

@iulianpascalau iulianpascalau merged commit b5d5392 into development Nov 17, 2021
@iulianpascalau iulianpascalau deleted the trie-sync-fixes-2021.10.13 branch November 17, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants