Gas limit tweaks #3601
Merged
Gas limit tweaks #3601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Nov 24, 2021
iulianpascalau
commented
- lowered max gas limit per miniblock, adapted high gas usage operation in gas schedule
Codecov Report
@@ Coverage Diff @@
## development #3601 +/- ##
===============================================
- Coverage 74.01% 74.00% -0.01%
===============================================
Files 582 582
Lines 74888 74888
===============================================
- Hits 55426 55424 -2
- Misses 15057 15058 +1
- Partials 4405 4406 +1
Continue to review full report at Codecov.
|
SebastianMarian
approved these changes
Nov 24, 2021
iulianpascalau
commented
Nov 24, 2021
| @@ -40,6 +40,7 @@ | |||
| GasLimitSettings = [ | |||
| {EnableEpoch = 0, MaxGasLimitPerBlock = "1500000000", MaxGasLimitPerMiniBlock = "1500000000", MaxGasLimitPerMetaBlock = "15000000000", MaxGasLimitPerMetaMiniBlock = "15000000000", MinGasLimit = "50000"}, | |||
| {EnableEpoch = 2, MaxGasLimitPerBlock = "1500000000", MaxGasLimitPerMiniBlock = "600000000", MaxGasLimitPerMetaBlock = "15000000000", MaxGasLimitPerMetaMiniBlock = "600000000", MinGasLimit = "50000"}, | |||
| {EnableEpoch = 3, MaxGasLimitPerBlock = "1500000000", MaxGasLimitPerMiniBlock = "500000000", MaxGasLimitPerMetaBlock = "15000000000", MaxGasLimitPerMetaMiniBlock = "500000000", MinGasLimit = "50000"}, | |||
There was a problem hiding this comment.
It seems that by mistake I have matched this epoch with the gas schedule v5 activation epoch:
[GasSchedule]
GasScheduleByEpochs = [
{ StartEpoch = 0, FileName = "gasScheduleV1.toml" },
{ StartEpoch = 1, FileName = "gasScheduleV4.toml" },
{ StartEpoch = 3, FileName = "gasScheduleV5.toml" },
]
sasurobert
approved these changes
Nov 24, 2021
gabi-vuls
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.