Payable by sc #3602
Merged
Payable by sc #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #3602 +/- ##
===============================================
- Coverage 74.00% 74.00% -0.01%
===============================================
Files 582 582
Lines 74888 74910 +22
===============================================
+ Hits 55424 55436 +12
- Misses 15058 15067 +9
- Partials 4406 4407 +1
Continue to review full report at Codecov.
|
camilbancioiu
previously approved these changes
Nov 24, 2021
| @@ -425,6 +439,10 @@ func (bh *BlockChainHookImpl) IsPayable(address []byte) (bool, error) { | |||
| } | |||
|
|
|||
| metadata := vmcommon.CodeMetadataFromBytes(userAcc.GetCodeMetadata()) | |||
| if bh.flagIsPayableBySC.IsSet() && bh.IsSmartContract(sndAddress) { | |||
| return metadata.Payable || metadata.PayableBySC, nil | |||
SebastianMarian
previously approved these changes
Nov 25, 2021
sasurobert
changed the base branch from
development
to
feat/SC-proc-improvements-NOV
sasurobert
dismissed
SebastianMarian’s stale review
The base branch was changed.
camilbancioiu
approved these changes
Nov 26, 2021
SebastianMarian
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature - contracts payable by SC.
Special testing: contract A transfers tokens for contract B - contract B is deployed as payable by contract.