En 10861 scheduled txs unit tests #3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us, add factoru for scheduled data syncer
consensus/spos/bls/export_test.go
Outdated
| @@ -213,6 +213,11 @@ func (sr *subroundBlock) ReceivedBlockHeader(cnsDta *consensus.Message) bool { | |||
| return sr.receivedBlockHeader(cnsDta) | |||
| } | |||
|
|
|||
| // ReceivedBlockBodyAndHeader is called when both a header and block body have been received t | |||
There was a problem hiding this comment.
Remove "t" from the end of the line
epochStart/bootstrap/process.go
Outdated
| @@ -201,6 +205,9 @@ func NewEpochStartBootstrap(args ArgsEpochStartBootstrap) (*epochStartBootstrap, | |||
| maxHardCapForMissingNodes: args.GeneralConfig.TrieSync.MaxHardCapForMissingNodes, | |||
| trieSyncerVersion: args.GeneralConfig.TrieSync.TrieSyncerVersion, | |||
| enableEpochs: args.EnableEpochs, | |||
| dataSyncerFactory: args.DataSyncerCreator, | |||
| storerScheduledSCRs: genericMocks.NewStorerMock("path", 0), | |||
There was a problem hiding this comment.
This storer should be mock?
There was a problem hiding this comment.
Right, it shouldn't be a mock here in productive code, but it can be initialized with nil, as it will get updated with the correct storer once the epoch is known.
| @@ -0,0 +1,20 @@ | |||
| package bootstrap | |||
There was a problem hiding this comment.
Missing comments for exported methods
| @@ -0,0 +1,26 @@ | |||
| package types | |||
There was a problem hiding this comment.
Missing comments for exported types
| @@ -51,7 +51,7 @@ func newStartInEpochShardHeaderDataSyncerWithScheduled( | |||
| }, nil | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Add comments for exported methods in this file
SebastianMarian
approved these changes
Dec 8, 2021
dragos-rebegea
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some unit tests and fixes