Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/round activation #3619

Merged
merged 33 commits into from
Dec 14, 2021
Merged

Feat/round activation #3619

merged 33 commits into from
Dec 14, 2021

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Dec 3, 2021

Added

  • RoundActivationHandler which:
  1. Can be queried either with IsEnabledInRound(name string, round uint64) or with IsEnabled -> which checks if the flag is enabled in the currently processed round
  2. Implements RoundConfirmed and updates its own internal "currently processing round"
  • enableRound.toml which contains all round activations (for now -> dummy)
  • RoundNotifier and RoundSubscriberHandler interfaces, which resemble EpochNotifier and EpochSubscriberHandler
  • roundNotifier implementation of RoundNotifier
  • RoundNotifier in coreComponents.go
  • Registered roundActivationHandler to roundNotifier in bootstrapComponents.go

mariusmihaic and others added 29 commits October 25, 2021 11:50
…oundManager_notification

# Conflicts:
#	process/roundActivation/roundActivation.go
#	process/roundActivation/roundActivation_test.go
…ification

En 11019 round manager notification
@mariusmihaic mariusmihaic self-assigned this Dec 3, 2021
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #3619 (a92be99) into development (0aaa0d4) will increase coverage by 0.01%.
The diff coverage is 75.77%.

❗ Current head a92be99 differs from pull request most recent head cfc93cd. Consider uploading reports for the commit cfc93cd to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3619      +/-   ##
===============================================
+ Coverage        73.67%   73.69%   +0.01%     
===============================================
  Files              585      587       +2     
  Lines            75435    75584     +149     
===============================================
+ Hits             55578    55698     +120     
- Misses           15448    15471      +23     
- Partials          4409     4415       +6     
Impacted Files Coverage Δ
factory/bootstrapComponentsHandler.go 61.40% <0.00%> (-7.23%) ⬇️
genesis/process/shardGenesisBlockCreator.go 43.06% <0.00%> (-0.09%) ⬇️
node/nodeRunner.go 0.00% <0.00%> (ø)
process/roundActivation/roundActivation.go 57.14% <57.14%> (ø)
common/configParser.go 26.76% <66.66%> (+3.68%) ⬆️
factory/bootstrapComponents.go 80.89% <71.42%> (-0.45%) ⬇️
vm/systemSmartContracts/esdt.go 82.21% <89.28%> (+0.16%) ⬆️
common/forking/roundNotifier.go 100.00% <100.00%> (ø)
factory/blockProcessorCreator.go 79.49% <100.00%> (+0.05%) ⬆️
factory/coreComponents.go 80.29% <100.00%> (+0.19%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01df53c...cfc93cd. Read the comment docs.

@AdoAdoAdo AdoAdoAdo marked this pull request as ready for review December 8, 2021 14:57
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.
Errors are safe.
image

@mariusmihaic mariusmihaic merged commit ce7b269 into development Dec 14, 2021
@mariusmihaic mariusmihaic deleted the feat/round-activation branch December 14, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants