Backwards compatibility fix on tx interceptor for gaslimit value #3624
Conversation
iulianpascalau
commented
Dec 6, 2021
iulianpascalau
commented
- removed backwards compatibility issue on transactions at interceptor level
- added protection on the API for transactions with higher gas limit than the transaction processor can cope
…r level - added protection on the API for transactions with higher gas limit than the transaction processor can cope
Codecov Report
@@ Coverage Diff @@
## development #3624 +/- ##
===============================================
- Coverage 73.69% 73.69% -0.01%
===============================================
Files 584 585 +1
Lines 75295 75317 +22
===============================================
+ Hits 55489 55503 +14
- Misses 15398 15405 +7
- Partials 4408 4409 +1
Continue to review full report at Codecov.
|
| }, nil | ||
| } | ||
|
|
||
| // CheckValidityTxValues checks if the provided transaction is economically correct. It overloads the original method |
There was a problem hiding this comment.
if the provided transaction is economically correct => if the provided transaction respects the gas limit restrictions
There was a problem hiding this comment.
actually it also checks other stuff other than the gas limit as it calls the overloaded method
| ) | ||
|
|
||
| func TestNewAPIEconomicsData(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
t.Parallel on each inner test, as right now the inner tests will be run serial
There was a problem hiding this comment.
please check. Can not be done.
| economicsData, _ := economics.NewEconomicsData(args) | ||
| apiEconomicsData, _ := economics.NewAPIEconomicsData(economicsData) | ||
|
|
||
| t.Run("maximum gas limit as defined should work", func(t *testing.T) { |
There was a problem hiding this comment.
t.Parallel() on each inner test
There was a problem hiding this comment.
please check. Can not be done.
Done
