Feat/index genesis transactions #3639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions Index genesis mint transactions
| @@ -16,6 +16,7 @@ | |||
| {Year = 11, MaximumInflation = 0.0}, | |||
| ] | |||
| Denomination = 18 # represents the smallest eGLD subdivision (10^-X eGLD for a denomination of X) | |||
| GenesisMintingSenderAddress = "erd17rc0pu8s7rc0pu8s7rc0pu8s7rc0pu8s7rc0pu8s7rc0pu8s7rcqqkhty3" | |||
There was a problem hiding this comment.
== "f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0" in hex
we could have this in the /examples/address_test.go
genesis/parsing/accountsParser.go
Outdated
| txs := make([]coreData.TransactionHandler, 0, len(ap.initialAccounts)) | ||
|
|
||
| var nonce uint64 = 0 | ||
| for _, ia := range ap.initialAccounts { |
There was a problem hiding this comment.
for nonce, ia := range ap.initialAccounts {
tx := ap.createMintTransaction(ia, uint64(nonce))
txs = append(txs, tx)
}
genesis/parsing/accountsParser.go
Outdated
| txsPoolPerShard[receiverShardID].Txs[string(txHash)] = tx | ||
|
|
||
| for _, miniBlock := range miniBlocks { | ||
| if (senderShardID == miniBlock.GetSenderShardID()) && |
There was a problem hiding this comment.
could have used a bool var. The parenthesis can be removed
factory/processComponents.go
Outdated
| var indexMiniBlocks = make([]*dataBlock.MiniBlock, 0) | ||
|
|
||
| for _, miniBlock := range miniBlocks { | ||
| if (miniBlock.GetSenderShardID() == shardId) || |
There was a problem hiding this comment.
could have used a bool var. Useless parenthesis
| _, err := tep.txProcessor.ProcessTransaction(tx) | ||
| return err | ||
| } | ||
|
|
||
| // GetTransactions will return the cached transactions | ||
| func (tep *txExecutionProcessor) GetTransactions() []data.TransactionHandler { |
There was a problem hiding this comment.
could have been named: GetExecutedTransactions
| DeployInitialScTxs: make([]data.TransactionHandler, 0), | ||
| } | ||
|
|
||
| return metaHdr, make([][]byte, 0), indexingData, nil |
There was a problem hiding this comment.
so we do not index the resulted transactions after a hardfork
There was a problem hiding this comment.
Not in this PR, as it is difficult to test at this moment.
There is some work to be done on the hardfork, but we could add a TODO
genesis/parsing/accountsParser.go
Outdated
| pubkeyConverter core.PubkeyConverter | ||
| keyGenerator crypto.KeyGenerator | ||
| hasher hashing.Hasher | ||
| marshalizer marshal.Marshalizer | ||
| } | ||
|
|
||
| // NewAccountsParser creates a new decoded accounts genesis structure from json config file | ||
| func NewAccountsParser( | ||
| genesisFilePath string, |
There was a problem hiding this comment.
could have switched to an argument DTO
…s-indexing Fixes after review - genesis indexing
bogdan-rosianu
previously approved these changes
Dec 16, 2021
…-genesis-txs Merge dev into feat index genesis txs
iulianpascalau
previously approved these changes
Dec 17, 2021
…twork/elrond-go into feat/index-genesis-transactions
Fix genesis enable epochs
AdoAdoAdo
dismissed stale reviews from iulianpascalau and bogdan-rosianu
via
233fd10
…twork/elrond-go into feat/index-genesis-transactions
…-genesis-txs Merge dev into feat index genesis txs
bogdan-rosianu
approved these changes
Dec 20, 2021
iulianpascalau
approved these changes
Dec 20, 2021
LucianMincu
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index genesis transactions and miniblocks: