Transform to multi create #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -150,7 +150,6 @@ func printEnableEpochs(configs *config.Configs) { | |||
| log.Debug(readEpochFor("esdt NFT create on multiple shards"), "epoch", enableEpochs.ESDTNFTCreateOnMultiShardEnableEpoch) | |||
| log.Debug(readEpochFor("SCR size invariant check"), "epoch", enableEpochs.SCRSizeInvariantCheckEnableEpoch) | |||
| log.Debug(readEpochFor("backward compatibility flag for save key value"), "epoch", enableEpochs.BackwardCompSaveKeyValueEnableEpoch) | |||
| log.Debug(readEpochFor("esdt NFT create on multiple shards"), "epoch", enableEpochs.ESDTNFTCreateOnMultiShardEnableEpoch) | |||
There was a problem hiding this comment.
why did we deleted this?
There was a problem hiding this comment.
It is duplicated.
| } | ||
|
|
||
| token.CanCreateMultiShard = true | ||
| isAddressLastByteZero := addressWithCreateRole[len(addressWithCreateRole)-1] == 0 |
There was a problem hiding this comment.
why do we need this?
There was a problem hiding this comment.
You do not need to put a new start nonce for the address which ends in zero. That address already made NFTs from 0 to X.
| e.eei.AddReturnMessage("it is already multi shard create") | ||
| return vmcommon.UserError | ||
| } | ||
|
|
There was a problem hiding this comment.
basicOwnershipChecks has inside a useGas
iulianpascalau
approved these changes
Dec 10, 2021
dragos-rebegea
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transform to multi create