Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arwen with safer upgradeFromSource #3644

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

sasurobert
Copy link
Contributor

just new arwen
Test: intrashard upgrade from source with not enough gas should error - before this branch it will not.

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #3644 (368df07) into development (3ef7498) will not change coverage.
The diff coverage is n/a.

❗ Current head 368df07 differs from pull request most recent head dace9d4. Consider uploading reports for the commit dace9d4 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           development    #3644   +/-   ##
============================================
  Coverage        73.71%   73.71%           
============================================
  Files              587      587           
  Lines            75654    75654           
============================================
  Hits             55768    55768           
  Misses           15467    15467           
  Partials          4419     4419           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3df6427...dace9d4. Read the comment docs.

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.
Errors are safe.
image

@gabi-vuls gabi-vuls merged commit 66c6ba9 into development Dec 15, 2021
@gabi-vuls gabi-vuls deleted the arwen-with-safer-upgradeFromAddress branch December 15, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants