Fixes after review - genesis indexing #3646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ssd04
commented
Dec 15, 2021
ssd04
commented
- fixes after review
- more unit tests
- set TxCount for genesis block header
bogdan-rosianu
requested changes
Dec 16, 2021
| &mock.HasherMock{}, | ||
| &mock.MarshalizerMock{}, | ||
| ) | ||
| args := genesis.AccountsParserArgs{ |
There was a problem hiding this comment.
usually we create an unexported function in the test file, something like createMockAccountsParserArgs and return a populated argument struct that will work as it is in the xxx_ShouldWork test.
On the other tests, like in the TestNewAccountsParser_NilEntireBalanceShouldErr we could have something like:
args := createMockAccountsParserArgs()
args.EntireSupply = nil
////.......In this way the duplicate code can be removed :)
There was a problem hiding this comment.
added additional function 👍
iulianpascalau
approved these changes
Dec 16, 2021
bogdan-rosianu
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.