-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix genesis enable epochs #3652
Fix genesis enable epochs #3652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the list of all new flags:
StakingV2EnableEpoch: unreachableEpoch,
StakeEnableEpoch: unreachableEpoch,
DoubleKeyProtectionEnableEpoch: unreachableEpoch,
ESDTEnableEpoch: unreachableEpoch,
GovernanceEnableEpoch: unreachableEpoch,
DelegationManagerEnableEpoch: unreachableEpoch,
DelegationSmartContractEnableEpoch: unreachableEpoch,
CorrectLastUnjailedEnableEpoch: unreachableEpoch,
BalanceWaitingListsEnableEpoch: unreachableEpoch,
ReturnDataToLastTransferEnableEpoch: unreachableEpoch,
UnbondTokensV2EnableEpoch: unreachableEpoch,
SaveJailedAlwaysEnableEpoch: unreachableEpoch,
ValidatorToDelegationEnableEpoch: unreachableEpoch,
ReDelegateBelowMinCheckEnableEpoch: unreachableEpoch,
WaitingListFixEnableEpoch: unreachableEpoch,
ESDTMultiTransferEnableEpoch: unreachableEpoch,
GlobalMintBurnDisableEpoch: unreachableEpoch,
ESDTTransferRoleEnableEpoch: unreachableEpoch,
ESDTNFTCreateOnMultiShardEnableEpoch: unreachableEpoch,
CorrectFirstQueuedEpoch: unreachableEpoch,
DeleteDelegatorAfterClaimRewardsEnableEpoch: unreachableEpoch,
StopDecreasingValidatorRatingWhenStuckEnableEpoch: unreachableEpoch,
FrontRunningProtectionEnableEpoch: unreachableEpoch,
IsPayableBySCEnableEpoch: unreachableEpoch,
CleanUpInformativeSCRsEnableEpoch: unreachableEpoch,
along with the MaxNodesChangeEnableEpoch
config struct
For a future PR: we might think of 2 specialized structs (that can implement one interface) that will have only getters. In this way we will better avoid forgetting to pass non-zero values in the arguments DTOs
}, | ||
BlockGasAndFeesReCheckEnableEpoch: unreachableEpoch, | ||
StakingV2EnableEpoch: unreachableEpoch, | ||
StakeEnableEpoch: unreachableEpoch, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be 0, otherwise the initial staking mechanism won't work on genesis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
BlockGasAndFeesReCheckEnableEpoch: unreachableEpoch, | ||
StakingV2EnableEpoch: unreachableEpoch, | ||
StakeEnableEpoch: unreachableEpoch, | ||
DoubleKeyProtectionEnableEpoch: unreachableEpoch, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be left to 0, there is an additional duplication check system on the read file but having this one activated, will make the genesis block creation fail, thus, having an early warning here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
No description provided.