Fix some trie prints on dev #3660
Conversation
trie/trieStorageManager.go
Outdated
| @@ -301,7 +301,10 @@ func (tsm *trieStorageManager) Get(key []byte) ([]byte, error) { | |||
| return nil, ErrContextClosing | |||
| } | |||
|
|
|||
| val, _ := tsm.mainStorer.Get(key) | |||
| val, err := tsm.mainStorer.Get(key) | |||
| if checkIfClosingError(err) { | |||
There was a problem hiding this comment.
is this ok? Shouldn't have been !checkIfClosingError(err) ? Also, I would call this simply isClosingError
Here and on L317, L329
There was a problem hiding this comment.
If there is a closing err, it should not continue to search in other dbs, but return the err. Changed the func name.
Codecov Report
@@ Coverage Diff @@
## development #3660 +/- ##
===============================================
- Coverage 73.70% 73.68% -0.02%
===============================================
Files 587 587
Lines 76011 76030 +19
===============================================
+ Hits 56022 56024 +2
- Misses 15552 15562 +10
- Partials 4437 4444 +7
Continue to review full report at Codecov.
|
Do not snapshot after start in epoch on peer trie. (this was done for the user trie on a previous PR)