Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix genesis header changes #3663

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Conversation

bogdan-rosianu
Copy link
Contributor

Use a clone of the genesis header when changing it for indexing genesis data. Otherwise, an observer would have lost sync with the network

@bogdan-rosianu bogdan-rosianu added the type:bug Something isn't working label Dec 23, 2021
@bogdan-rosianu bogdan-rosianu self-assigned this Dec 23, 2021
@ssd04 ssd04 self-requested a review December 23, 2021 13:34
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #3663 (9899a97) into development (53ac8a8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #3663   +/-   ##
============================================
  Coverage        73.68%   73.68%           
============================================
  Files              587      587           
  Lines            76030    76031    +1     
============================================
+ Hits             56024    56027    +3     
+ Misses           15562    15561    -1     
+ Partials          4444     4443    -1     
Impacted Files Coverage Δ
factory/processComponents.go 64.24% <100.00%> (+0.03%) ⬆️
p2p/libp2p/netMessenger.go 75.00% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 831ec19...9899a97. Read the comment docs.

@LucianMincu LucianMincu merged commit 957a2ff into development Dec 23, 2021
@LucianMincu LucianMincu deleted the fix-genesis-header-changes branch December 23, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants