Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer with double types #3665

Merged
merged 7 commits into from
Jan 5, 2022
Merged

indexer with double types #3665

merged 7 commits into from
Jan 5, 2022

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Dec 28, 2021

Indexer with double types instead of unsigned_long

@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #3665 (e8c6acf) into development (f5b950c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3665      +/-   ##
===============================================
- Coverage        73.68%   73.68%   -0.01%     
===============================================
  Files              587      587              
  Lines            76040    76040              
===============================================
- Hits             56031    56028       -3     
- Misses           15565    15568       +3     
  Partials          4444     4444              
Impacted Files Coverage Δ
debug/resolver/interceptorResolver.go 77.77% <0.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412fc02...e8c6acf. Read the comment docs.

gabi-vuls
gabi-vuls previously approved these changes Jan 5, 2022
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.
Errors are safe and will be solved with a future PR.
image

ssd04
ssd04 previously approved these changes Jan 5, 2022
go.mod Outdated
@@ -8,7 +8,7 @@ require (
github.com/ElrondNetwork/arwen-wasm-vm/v1_4 v1.4.33
github.com/ElrondNetwork/concurrent-map v0.1.3
github.com/ElrondNetwork/covalent-indexer-go v1.0.6
github.com/ElrondNetwork/elastic-indexer-go v1.1.31
github.com/ElrondNetwork/elastic-indexer-go v1.1.32-0.20211229124909-dcb4634e9425
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proper release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@miiu96 miiu96 dismissed stale reviews from ssd04 and gabi-vuls via e8c6acf January 5, 2022 12:58
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@miiu96 miiu96 merged commit 7aeea39 into development Jan 5, 2022
@miiu96 miiu96 deleted the indexer-with-double-types branch January 5, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants