No process error on shuffle out #3698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Jan 13, 2022
iulianpascalau
commented
- suppressed original processing errors when the node is shuffling between shards
Codecov Report
@@ Coverage Diff @@
## development #3698 +/- ##
===============================================
- Coverage 73.76% 73.76% -0.01%
===============================================
Files 587 588 +1
Lines 76073 76091 +18
===============================================
+ Hits 56116 56129 +13
- Misses 15520 15525 +5
Partials 4437 4437
Continue to review full report at Codecov.
|
bogdan-rosianu
requested changes
Jan 13, 2022
bogdan-rosianu
previously approved these changes
Jan 13, 2022
bogdan-rosianu
previously approved these changes
Jan 13, 2022
SebastianMarian
previously approved these changes
Jan 13, 2022
process/sync/baseSync.go
Outdated
| @@ -502,6 +502,11 @@ func (boot *baseBootstrap) syncBlocks(ctx context.Context) { | |||
|
|
|||
| err := boot.syncStarter.SyncBlock() | |||
There was a problem hiding this comment.
There is another err log in this method which could be avoided if we also send ctx there. I don't have a strong opinion if it is mandatory to be done also there, as we log here that the go routine is stopping.
There was a problem hiding this comment.
Right, the correct process there is to replace the error
iulianpascalau
dismissed stale reviews from SebastianMarian and bogdan-rosianu
via
71658d3
SebastianMarian
previously approved these changes
Jan 13, 2022
SebastianMarian
approved these changes
Jan 14, 2022
bogdan-rosianu
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.