Snapshot after sync fix #3706
Merged
Snapshot after sync fix #3706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #3706 +/- ##
===============================================
- Coverage 73.79% 73.78% -0.02%
===============================================
Files 589 589
Lines 76199 76213 +14
===============================================
+ Hits 56229 56231 +2
- Misses 15521 15534 +13
+ Partials 4449 4448 -1
Continue to review full report at Codecov.
|
iulianpascalau
previously approved these changes
Jan 18, 2022
| @@ -741,18 +741,42 @@ func (tsm *trieStorageManager) ShouldTakeSnapshot() bool { | |||
| return false | |||
| } | |||
|
|
|||
| if isTrieSynced(stsm) { | |||
AdoAdoAdo
previously approved these changes
Jan 18, 2022
AdoAdoAdo
dismissed stale reviews from iulianpascalau and themself
via
220d4a2
iulianpascalau
approved these changes
Jan 19, 2022
AdoAdoAdo
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip snapshot if trie was synced