-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oom fixes 2022.01.19 #3709
Oom fixes 2022.01.19 #3709
Conversation
iulianpascalau
commented
Jan 19, 2022
•
edited
edited
- made the db pointer inside the storers implementation nil whenever we call Close or Destroy. Added nil checks on all usages of the db pointer.
- peer accounts trie snapshot for shard nodes so the pruning storer for the peer accounts will not cause OOMs
- minor storers refactor: used context instead of chan
…we call Close or Destroy. Added nil checks on all usages of the db pointer.
Codecov Report
@@ Coverage Diff @@
## development #3709 +/- ##
============================================
Coverage 73.78% 73.79%
============================================
Files 589 589
Lines 76218 76312 +94
============================================
+ Hits 56241 56316 +75
- Misses 15530 15545 +15
- Partials 4447 4451 +4
Continue to review full report at Codecov.
|
3b3bdbb
to
5e83322
Compare
fdcccbf
- tentative OOM fix
- added several tests, added minor pruning storer fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System test passed.