Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexer with additional data #3716

Merged
merged 3 commits into from
Jan 31, 2022
Merged

Indexer with additional data #3716

merged 3 commits into from
Jan 31, 2022

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Jan 21, 2022 •
edited

  • Latest indexer
  • Latest elrond-go-core

iulianpascalau
iulianpascalau reviewed Jan 24, 2022
View reviewed changes
go.mod Outdated
@@ -8,8 +8,8 @@ require (
github.com/ElrondNetwork/arwen-wasm-vm/v1_4 v1.4.34
github.com/ElrondNetwork/concurrent-map v0.1.3
github.com/ElrondNetwork/covalent-indexer-go v1.0.6
github.com/ElrondNetwork/elastic-indexer-go v1.1.33-0.20220106100817-3e1d9f0a09a2
github.com/ElrondNetwork/elrond-go-core v1.1.8-0.20220119114821-a52f4e9a6107
github.com/ElrondNetwork/elastic-indexer-go v1.1.33-0.20220121140547-423802ef8fff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proper release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Base automatically changed from feat/scheduled-sc-execution to development January 31, 2022 14:39
@codecov
Copy link

codecov bot commented Jan 31, 2022 •
edited

Codecov Report

Merging #3716 (1743465) into development (e9d4ed2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #3716   +/-   ##
============================================
  Coverage        73.65%   73.65%           
============================================
  Files              599      599           
  Lines            79149    79149           
============================================
  Hits             58300    58300           
  Misses           16262    16262           
  Partials          4587     4587

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1460361...1743465. Read the comment docs.

gabi-vuls
gabi-vuls approved these changes Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@gabi-vuls gabi-vuls merged commit 649783a into development Jan 31, 2022
@gabi-vuls gabi-vuls deleted the indexer-with-additional-data-header-v2 branch January 31, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstanculeanu sstanculeanu sstanculeanu approved these changes

@AdoAdoAdo AdoAdoAdo AdoAdoAdo approved these changes

@iulianpascalau iulianpascalau iulianpascalau approved these changes

@gabi-vuls gabi-vuls gabi-vuls approved these changes

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@miiu96 @sstanculeanu @AdoAdoAdo @iulianpascalau @gabi-vuls @bogdan-rosianu