Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error on genesis block save #3720

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

iulianpascalau
Copy link
Contributor

  • fixed error on genesis block save
  • switched some prints to log level TRACE

- switched some prints to log level TRACE
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #3720 (bbcfef9) into development (220d4a2) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #3720   +/-   ##
============================================
  Coverage        73.78%   73.78%           
============================================
  Files              589      589           
  Lines            76213    76218    +5     
============================================
+ Hits             56231    56237    +6     
+ Misses           15534    15532    -2     
- Partials          4448     4449    +1     
Impacted Files Coverage Δ
genesis/process/genesisBlockCreator.go 16.33% <0.00%> (-0.05%) ⬇️
trie/trieStorageManager.go 62.70% <40.00%> (ø)
factory/processComponents.go 64.40% <52.38%> (+0.15%) ⬆️
dataRetriever/chainStorer.go 100.00% <100.00%> (ø)
p2p/libp2p/netMessenger.go 74.72% <0.00%> (-0.28%) ⬇️
dataRetriever/interface.go 12.90% <0.00%> (+12.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f69d1...bbcfef9. Read the comment docs.

dragos-rebegea
dragos-rebegea previously approved these changes Jan 24, 2022
Copy link
Collaborator

@andreibancioiu andreibancioiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I confirm that the method extraction (which resulted in the new saveMetaBlock() and saveShardBlock()) is a safe refactoring (checked diff).

Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit b4b3aa9 into development Jan 24, 2022
@LucianMincu LucianMincu deleted the fix-error-genesis-block-save branch January 24, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants