Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatibility fixes 2022.01.27 #3724

Merged
merged 3 commits into from
Jan 28, 2022

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented Jan 27, 2022

  • backwards compatibility fix by using old method of retrieving the ESDT token from the trie. The legacy function is tight to the optimize nft metadata store flag
  • fixed the forgotten epoch configs flags on the blockchain hook implementation

…SDT token from the trie. The legacy function is tight to the `optimize nft metadata store` flag

- fixed the forgotten epoch configs flags on the blockchain hook implementation
@iulianpascalau iulianpascalau marked this pull request as draft January 27, 2022 12:45
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #3724 (f8832a8) into development (5c7f6c7) will increase coverage by 0.01%.
The diff coverage is 80.85%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3724      +/-   ##
===============================================
+ Coverage        73.79%   73.81%   +0.01%     
===============================================
  Files              589      589              
  Lines            76312    76338      +26     
===============================================
+ Hits             56316    56348      +32     
+ Misses           15545    15538       -7     
- Partials          4451     4452       +1     
Impacted Files Coverage Δ
factory/apiResolverFactory.go 0.00% <0.00%> (ø)
genesis/process/genesisBlockCreator.go 16.29% <0.00%> (-0.05%) ⬇️
genesis/process/shardGenesisBlockCreator.go 39.10% <71.42%> (-0.04%) ⬇️
process/smartContract/hooks/blockChainHook.go 63.63% <93.75%> (+4.95%) ⬆️
factory/blockProcessorCreator.go 79.57% <100.00%> (+0.05%) ⬆️
genesis/process/metaGenesisBlockCreator.go 47.44% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67f77b6...f8832a8. Read the comment docs.

@iulianpascalau iulianpascalau marked this pull request as ready for review January 28, 2022 06:05
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

  Object          Number       Verdict

Known ERRORS 5 Passed
New ERRORS 0 Passed
WARNs 1322 Passed
PANICs 0 Passed

@LucianMincu LucianMincu merged commit 11799f8 into development Jan 28, 2022
@LucianMincu LucianMincu deleted the backwards-comp-fix-2022.01.27 branch January 28, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants