process, integrationTests, testscommon: fix total gas provided with scheduled SC calls #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## fix-edge-case-of-set-scheduled-scrs-at-bootstrap #3743 +/- ##
=================================================================================
Coverage 73.66% 73.66%
=================================================================================
Files 599 599
Lines 79167 79162 -5
=================================================================================
Hits 58315 58315
+ Misses 16266 16260 -6
- Partials 4586 4587 +1
Continue to review full report at Codecov.
|
SebastianMarian
previously approved these changes
Feb 2, 2022
AdoAdoAdo
changed the base branch from
development
to
fix-edge-case-of-set-scheduled-scrs-at-bootstrap
…fix-total-gas-provided-with-scheduled
iulianpascalau
approved these changes
Feb 2, 2022
iulianpascalau
approved these changes
Feb 2, 2022
SebastianMarian
approved these changes
Feb 2, 2022
| @@ -906,11 +906,21 @@ func (txs *transactions) getAllTxsFromMiniBlock( | |||
| } | |||
|
|
|||
| func (txs *transactions) getRemainingGasPerBlock() uint64 { | |||
| gasConsumed := txs.getTotalGasConsumed() | |||
| gasProvided := txs.getTotalGasConsumed() | |||
There was a problem hiding this comment.
Actually this is really consumed as in getTotalGasConsumed method, from total gas provided is subtracted gas penalized and gas refunded if they exist
iulianpascalau
approved these changes
Feb 2, 2022
AdoAdoAdo
force-pushed
the
fix-total-gas-provided-with-scheduled
branch
from
01da2f9
to
0c82a8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.