Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log Warn in block tracker pools cleanup mechanism #4022

Merged

Conversation

SebastianMarian
Copy link
Contributor

  • Fixed Warn messages in block tracker pools cleanup mechanism

@SebastianMarian SebastianMarian self-assigned this Apr 27, 2022
- minor code refactoring
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #4022 (0603fc6) into rc/2022-may (6ba812d) will increase coverage by 0.00%.
The diff coverage is 63.63%.

❗ Current head 0603fc6 differs from pull request most recent head 206e3cd. Consider uploading reports for the commit 206e3cd to get more accurate results

@@             Coverage Diff              @@
##           rc/2022-may    #4022   +/-   ##
============================================
  Coverage        74.79%   74.79%           
============================================
  Files              609      609           
  Lines            80944    80953    +9     
============================================
+ Hits             60540    60547    +7     
- Misses           15769    15770    +1     
- Partials          4635     4636    +1     
Impacted Files Coverage Δ
process/block/baseProcess.go 69.08% <61.90%> (+0.07%) ⬆️
process/block/preprocess/transactions.go 61.89% <100.00%> (ø)
storage/txcache/txListBySenderMap.go 97.50% <0.00%> (-2.50%) ⬇️
p2p/libp2p/netMessenger.go 75.00% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8e8ae...206e3cd. Read the comment docs.

@iulianpascalau iulianpascalau self-assigned this Apr 27, 2022
@dragos-rebegea dragos-rebegea self-requested a review April 27, 2022 09:45
dragos-rebegea
dragos-rebegea previously approved these changes Apr 27, 2022
sstanculeanu
sstanculeanu previously approved these changes Apr 27, 2022
bogdan-rosianu
bogdan-rosianu previously approved these changes Apr 27, 2022
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@@ Log scanner @@

fix-log-warn-in-block-tracker-pools-cleanup

================================================================================

  • Known Warnings 10
  • New Warnings 1
  • Known Errors 0
  • New Errors 0
  • Panics 0
    ================================================================================

@iulianpascalau iulianpascalau merged commit 49a4949 into rc/2022-may Apr 27, 2022
@iulianpascalau iulianpascalau deleted the fix-log-warn-in-block-tracker-pools-cleanup branch April 27, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants