Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logs order #4025

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Fix logs order #4025

merged 3 commits into from
Apr 27, 2022

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Apr 27, 2022

  • Fix the order in how the logs are generated.
  • The logs generated by a built-in function with a smart contract call were put last instead of first.

@iulianpascalau iulianpascalau changed the base branch from master to rc/2022-may April 27, 2022 12:48
@iulianpascalau iulianpascalau changed the base branch from rc/2022-may to master April 27, 2022 12:48
@iulianpascalau iulianpascalau changed the base branch from master to rc/2022-may April 27, 2022 12:48
@iulianpascalau iulianpascalau self-requested a review April 27, 2022 12:49
@miiu96 miiu96 self-assigned this Apr 27, 2022
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #4025 (9ca5fe3) into rc/2022-may (0603fc6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9ca5fe3 differs from pull request most recent head 31a300a. Consider uploading reports for the commit 31a300a to get more accurate results

@@               Coverage Diff               @@
##           rc/2022-may    #4025      +/-   ##
===============================================
- Coverage        74.79%   74.78%   -0.01%     
===============================================
  Files              609      609              
  Lines            80953    80953              
===============================================
- Hits             60547    60544       -3     
- Misses           15770    15772       +2     
- Partials          4636     4637       +1     
Impacted Files Coverage Δ
process/smartContract/process.go 68.86% <100.00%> (ø)
p2p/libp2p/netMessenger.go 74.58% <0.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49a4949...31a300a. Read the comment docs.

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@gabi-vuls gabi-vuls merged commit 206c320 into rc/2022-may Apr 27, 2022
@gabi-vuls gabi-vuls deleted the fix-logs-order branch April 27, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants