-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary gasComputation.Reset call #4535
Conversation
Codecov ReportBase: 73.93% // Head: 73.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4535 +/- ##
=======================================
Coverage 73.93% 73.93%
=======================================
Files 679 679
Lines 86969 86968 -1
=======================================
+ Hits 64298 64301 +3
+ Misses 17866 17864 -2
+ Partials 4805 4803 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System test passed.
Description of the reasoning behind the pull request
SetGasProvided
were done on a several hundreds of transactions and up. The time consumed was caused that each transaction hash from the miniblock was added as record in the map that was latter used to append each executed hash, causing exponential time of execution consumed.Proposed Changes
Testing procedure