Save log in file #100
Merged
Save log in file #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan-rosianu
requested changes
Oct 22, 2020
There was a problem hiding this comment.
Along awaited feature 💯 🥳
Please resolve @bogdan-rosianu's comments.
| @@ -3,9 +3,9 @@ module github.com/ElrondNetwork/elrond-proxy-go | |||
| go 1.12 | |||
|
|
|||
| require ( | |||
| github.com/ElrondNetwork/elrond-go v1.1.1-0.20200914111912-d1792d662b8f | |||
| github.com/ElrondNetwork/elrond-go v1.1.2-0.20201016080150-915a6ef433de | |||
There was a problem hiding this comment.
Not sure, but - can we reference v1.1.3 already perhaps?
bogdan-rosianu
approved these changes
Oct 27, 2020
andreibancioiu
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an extra flag that will specify to save logs in a file.
Also now proxy can start with different log levels ( --log-level *:INFO, DEBUG or TRACE)