Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra field in transaction structure #102

Merged
merged 5 commits into from
Nov 16, 2020
Merged

Extra field in transaction structure #102

merged 5 commits into from
Nov 16, 2020

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Oct 27, 2020

Added field options in transaction structure

bogdan-rosianu
bogdan-rosianu requested changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@bogdan-rosianu bogdan-rosianu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is fine, but don't merge until the elrond-go branch is merged

@andreibancioiu
Copy link
Contributor

PR is fine, but don't merge until the elrond-go branch is merged

Let's merge it though - two-ways compatible, right? Or not?

@andreibancioiu andreibancioiu merged commit 45161b8 into development Nov 16, 2020
@andreibancioiu andreibancioiu deleted the EN-7923-add-field-options-in-tx branch November 16, 2020 18:09
@andreibancioiu andreibancioiu mentioned this pull request Dec 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreibancioiu andreibancioiu andreibancioiu approved these changes

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miiu96 @andreibancioiu @bogdan-rosianu