EN-5584: endpoint for getting key-value pairs for addresses #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
approved these changes
Feb 12, 2021
| apiResponse := data.GenericAPIResponse{} | ||
| apiPath := AddressPath + address + "/keys" | ||
| respCode, err := ap.proc.CallGetRestEndPoint(observer.Address, apiPath, &apiResponse) | ||
| if err == nil || respCode == http.StatusBadRequest || respCode == http.StatusInternalServerError { |
There was a problem hiding this comment.
Is this condition ok? Maybe you can extract it in one explanatory variable.
There was a problem hiding this comment.
Yes. It is correct. If you look inside CallGetRestEndPoint function it can return values on both return params (the response code and the error) so this check must be made in order to return if a request isn't 200 OK.
I tried to extract a variable, but I would get an IDE's linter issue that tells me the err can be nil when logging it. I would leave it as it is
SebastianMarian
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the
address/{address}/keysendpoint that will return a map containing all keys and their values for an account. The value is represented in hexadecimal encoding.