Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to find license information for ignored license #16

Closed
phrohdoh opened this issue Aug 18, 2019 · 7 comments
Closed

Fails to find license information for ignored license #16

phrohdoh opened this issue Aug 18, 2019 · 7 comments
Labels
bug Something isn't working

Comments

@phrohdoh
Copy link
Contributor

Describe the bug

Before ignoring (via deny.toml) *ring*'s LICENSE, when running cargo deny check I see the following.

Aug 18 07:15:42.345 ERRO unable to determine license with high confidence, src: text=/Users/taryn/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.14.6/LICENSE,hash=0xbd0eed23, score: 0.6644706, crate: ring@0.14.6

I then add the following to my deny.toml.

[[licenses.ignore]]
name = "ring"
license_files = [
    { path = "LICENSE", hash = 0xbd0eed23 },
]

Upon running cargo deny check again I see the following.

Aug 18 07:17:22.179 ERRO could not find any license information, crate: ring@0.14.6

To Reproduce

  • have *ring* as a dependency (direct or transitive)
  • perform the above-noted steps

Expected Behavior

I expect *ring* to be successfully ignored.

Additional Information

I am using cargo-deny version 0.2.6.

@phrohdoh phrohdoh added the bug Something isn't working label Aug 18, 2019
@phrohdoh
Copy link
Contributor Author

Note that I have the exact same issue with webpki@0.19.1.

@Jake-Shadle
Copy link
Member

Jake-Shadle commented Aug 18, 2019

Since you are ignoring the only license file cargo-deny won't then have any licenses for ring, so you will also need to add it to the skip list, which you can just copy from this repo's deny.toml .

@Jake-Shadle
Copy link
Member

We have the exact same setup, and I realized this configuration is a little weird, will come up with a way for it to be a little more simple!

@phrohdoh
Copy link
Contributor Author

Adding it to the skip list doesn't change the behavior.

Aug 18 08:06:14.597 ERRO could not find any license information, crate: ring@0.14.6

@Jake-Shadle
Copy link
Member

Are you certain it's the skip list for [licenses] (and not commented out)?

@phrohdoh
Copy link
Contributor Author

phrohdoh commented Aug 18, 2019

You are absolutely correct, I had put it in [bans] instead of [licenses].
Thank you!

@Jake-Shadle
Copy link
Member

Cool, glad I was able to help! I've opened #17 to address the weirdness with configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants