Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple advisory databases #69

Closed
Jake-Shadle opened this issue Dec 19, 2019 · 2 comments · Fixed by #244
Closed

Add support for multiple advisory databases #69

Jake-Shadle opened this issue Dec 19, 2019 · 2 comments · Fixed by #244
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Jake-Shadle
Copy link
Member

Currently cargo-deny is restricted to using one advisory database at a time via the db-url configuration setting. It would be useful to support multiple databases in parallel, particularly for unmaintained advisories, so that we can point our configuration at our own database while either a PR to the official advisory-db is pending, or just that we might want to be a more aggressive with particular crates compared to the rest of the ecosystem.

@Jake-Shadle Jake-Shadle added the enhancement New feature or request label Dec 19, 2019
@Jake-Shadle Jake-Shadle added the good first issue Good for newcomers label Feb 13, 2020
@Stupremee
Copy link
Contributor

How would you handle backwards-compatibility if you add this feature?
Just removing the db-url entry and replace it with db-urls (or something similar) doesn't sound like a good idea.

Probably add another db-urls config entry and keep the db-url parameter and the concatenate them both and probably give a warning that db-url is deprecated.

@Jake-Shadle
Copy link
Member Author

That would be an option, as well as allowing either a single string or an array for the db-url field by doing something like https://serde.rs/string-or-struct.html, but I think your option is probably better, I don't think many people override the url to point to something other than the default, so deprecating it it would be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
2 participants