Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interior rendering lighting changes based on world position #40

Closed
dtrebilco opened this issue Jan 12, 2022 · 3 comments
Closed

Interior rendering lighting changes based on world position #40

dtrebilco opened this issue Jan 12, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@dtrebilco
Copy link

dtrebilco commented Jan 12, 2022

Describe the bug
It seems that interior areas are well lit and do not match the reference at all when at different world positions.

I am attempting to render a house and at the origin it renders correctly (according to the reference - light not coming through windows is a different issue)
Interior

Walking down the house (scale is 1 unit = 1m in case that makes a difference) there is a transition area where light is coming from "somewhere"
Transition

Here is the reference of that area
Transition_ref

Until the front rooms are fully lit
FrontRoom

Reference:
FrontRoom_ref

If I move the house in the scene file (say by 10m), the lit areas move around the house

I am guessing that perhaps there is some setting where interior lighting is only performed correctly at some small distance from the origin? Or perhaps there is some world light that starts at this position?

Let me know if it would be helpful to have the sample data - I will see if I can get permission to supply a cut down version.

Device:

  • OS: Windows 10
  • Version: Git sysnch of 10 January 2022
@dtrebilco dtrebilco added the bug Something isn't working label Jan 12, 2022
@h3r2tic
Copy link
Collaborator

h3r2tic commented Jan 12, 2022

Cool scene!

This one is the fixed-size GI volume scale that README.md mentions:

  • The voxel GI uses a fixed-size volume around the origin by default.
    • Use --gi-volume-scale to change its extent in the view app
    • It can be configured to use camera-centered cascades at an extra performance cost (see CASCADE_COUNT and SCROLL_CASCADES in csgi.rs)

Try with, say, --gi-volume-scale 2, then see if it's still there, and if not, go higher.

@dtrebilco
Copy link
Author

Thanks that works fine - sorry I missed that in the readme.

@h3r2tic
Copy link
Collaborator

h3r2tic commented Jan 12, 2022

No worries! Glad to hear the parameter worked out fine 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants