Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running cargo deny check with krates 0.16.5 panics #76

Closed
upbqdn opened this issue Jan 24, 2024 · 1 comment · Fixed by #77
Closed

Running cargo deny check with krates 0.16.5 panics #76

upbqdn opened this issue Jan 24, 2024 · 1 comment · Fixed by #77
Assignees
@Jake-Shadle
Labels
bug Something isn't working

Comments

@upbqdn
Copy link

upbqdn commented Jan 24, 2024

Describe the bug

Running

RUST_BACKTRACE=1 cargo deny check

for this project https://github.com/ZcashFoundation/zebra fails with:

thread '<unnamed>' panicked at /.../.cargo/registry/src/index.crates.io-6f17d22bba15001f/krates-0.16.5/src/builder.rs:1183:48:
cargo metadata resolved a dependency for a dependency not specified by the crate: NodeDep { name: "zebra_chain", pkg: Kid { name: "zebra-chain", version: "1.0.0-beta.34", source: "path+file:///.../zebra/zebra-chain" }, dep_kinds: [DepKindInfo { kind: Normal, cfg: None }, DepKindInfo { kind: Dev, cfg: None }] }
stack backtrace:
   0: rust_begin_unwind
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:645:5
   1: core::panicking::panic_fmt
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/panicking.rs:72:14
   2: <core::slice::iter::Iter<T> as core::iter::traits::iterator::Iterator>::find_map
   3: krates::builder::Builder::build_with_metadata
   4: cargo_deny::common::KrateContext::gather_krates
   5: std::panicking::try
   6: <rayon_core::job::HeapJob<BODY> as rayon_core::job::Job>::execute
   7: rayon_core::registry::WorkerThread::wait_until_cold
   8: rayon_core::registry::ThreadBuilder::run
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

You can also see the error in the CI of the project: https://github.com/ZcashFoundation/zebra/actions/runs/7639791083/job/20814504342?pr=8185#step:5:14.

To Reproduce
Steps to reproduce the behavior:

  1. Clone https://github.com/ZcashFoundation/zebra
  2. Run cargo deny check

Device:

  • OS: Arch Linux
@upbqdn upbqdn added the bug Something isn't working label Jan 24, 2024
@Jake-Shadle Jake-Shadle self-assigned this Jan 24, 2024
@Jake-Shadle Jake-Shadle mentioned this issue Jan 24, 2024
Closed
@upbqdn
Copy link
Author

upbqdn commented Jan 24, 2024

I didn't investigate the panic in the code, but cargo deny version 0.14.8 works, so the bug was likely introduced in #75.

@upbqdn upbqdn mentioned this issue Jan 24, 2024
Closed
@Jake-Shadle Jake-Shadle mentioned this issue Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jake-Shadle Jake-Shadle

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pre-releases EmbarkStudios/krates
2 participants
@Jake-Shadle @upbqdn