Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more resets #80

Closed
TheMan6900 opened this issue May 20, 2024 · 6 comments
Closed

Add more resets #80

TheMan6900 opened this issue May 20, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@TheMan6900
Copy link

Add a reset settings button for Gamemode, Modifer, Blacklist, since there all gonna be saveable next update

@EmeraldLoc
Copy link
Owner

EmeraldLoc commented May 20, 2024

Bold claim. Blacklist's won't be saved next update, as I don't want to run out of keys. I will be saving gamemode and modifier settings however.

Edit: Currently tag has a maximum keyspace of ~100. I thought the maximum keys allowed was 128. Well, I was wrong. The maximum amount of keys is 255, so, I take bac what I said, I may save blacklists

@EmeraldLoc EmeraldLoc added the enhancement New feature or request label May 20, 2024
@TheMan6900
Copy link
Author

TheMan6900 commented May 20, 2024

alright

Edit: Yippee

@TheMan6900
Copy link
Author

Oh yeah, This would also apply to blacklisting modifiers, and gamemodes, since those will also be saveable

@EmeraldLoc
Copy link
Owner

Really making a whole lotta claims here with no evidence, nonetheless you're right. Level blacklists won't be saved due to it taking a ridiculous amount of keys, I will be saving gamemode and modifier blacklists however. Gonna close this, i'd rather you make issues for the blacklists saving and the gamemdoes saving (whihc you have), and the modifiers aving (which you have). Common sense should tell me to add a reset button, so :)

@TheMan6900
Copy link
Author

I mean why wouldnt you add saving for blacklisting gamemodes and modifiers, if your gonna do saving for gamemodes and modifier settings?

@EmeraldLoc
Copy link
Owner

I literally said I was? And if there was a reason, it would be the amount of keys allowed. There is currently as of right now 117 keys total, that's with gamemode and modifier settings being saved. Adding modifiers and gamemode's corresponding blacklists causes a total of 149 keys, so, we're currently still ok when it comes to keys, since the max is 255, so I will add this feature. If the max was, say, 155, I wouldn't add it as I want to leave room for more achievements (since an achievement takes 1 key slot to decide if it's unlocked or not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants