Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Additional Animation Parameters for Shine ChangeEffect #10

Closed
mergesort opened this issue Oct 18, 2022 · 2 comments · Fixed by #13
Closed

Feature Request: Additional Animation Parameters for Shine ChangeEffect #10

mergesort opened this issue Oct 18, 2022 · 2 comments · Fixed by #13
Labels
Enhancement New feature or request

Comments

@mergesort
Copy link
Collaborator

I hope this is the right place to ask for more fine tuning, but either way thank you very much for the library!

I was trying to use the .shine ChangeEffect for animating a button tap, but the animation duration is too long for my use case. I see that other ChangeEffect's have parameters to try and fine tune the animation, and was hoping that it would be possible to add additional parameters to .shine. While I only want the timing to be faster, I could see the edges being exposed as a parameter being useful to others as well, but I'll leave that to your best discretion.

Happy to provide any more information that may be useful, and thank you again!

@robb
Copy link
Contributor

robb commented Oct 23, 2022

Hi @mergesort,

thanks for reaching out – I think that's a reasonable request, we'll look into it and will report back shortly.

@mergesort
Copy link
Collaborator Author

Thanks a lot! In that case I'd like to expand the request a tiny bit to ask for more generally any ChangeEffect or Transition that has tunable parameters to expose those. No rush of course, have a great weekend. 🙂

@robb robb mentioned this issue Oct 25, 2022
@robb robb added the Enhancement New feature or request label Oct 25, 2022
@robb robb closed this as completed in #13 Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants