Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken on Python 3.10 #24

Closed
TheFrenchGhosty opened this issue Mar 12, 2022 · 16 comments
Closed

Broken on Python 3.10 #24

TheFrenchGhosty opened this issue Mar 12, 2022 · 16 comments

Comments

@TheFrenchGhosty
Copy link

Both scripts doesn't seem to work on Python 3.10:

itch-download:

Traceback (most recent call last):
  File "/home/user/.local/bin/itch-download", line 8, in <module>
    sys.exit(main())
  File "/home/user/.local/lib/python3.10/site-packages/itchiodl/downloader/__main__.py", line 21, in main
    l = itchiodl.LoginAPI(user, password)
  File "/home/user/.local/lib/python3.10/site-packages/itchiodl/login.py", line 29, in LoginAPI
    raise RuntimeError
RuntimeError

itch-load-bundle:

Traceback (most recent call last):
  File "/home/user/.local/bin/itch-load-bundle", line 8, in <module>
    sys.exit(main())
  File "/home/user/.local/lib/python3.10/site-packages/itchiodl/bundle_tool/__main__.py", line 12, in main
    b.load_games()
  File "/home/user/.local/lib/python3.10/site-packages/itchiodl/bundle.py", line 14, in load_games
    pages = int(s.select("span.pager_label a")[-1].text)
IndexError: list index out of range

Works fine on Python 3.9

@Emersont1
Copy link
Owner

I'm running python 3.10.2 on my machine and it works fine, these seem to be more issues with you logging in?

@Emersont1
Copy link
Owner

I think the first one is a duplicate of #22

I need to do some more experiments, but I think if you've not logged into the desktop app before running this, it won't work.

@TheFrenchGhosty
Copy link
Author

@Emersont1

I need to do some more experiments, but I think if you've not logged into the desktop app before running this, it won't work.

With Python 3.9 I don't need to login into the desktop app.

@Emersont1
Copy link
Owner

Have you tried with an API key?

@TheFrenchGhosty
Copy link
Author

First issue doesn't appear with an API key... which is weird considering Username/Password works fine with 3.9

@Emersont1
Copy link
Owner

Username/Password works flawlessly on 3.10.2 on my machine.

@Emersont1
Copy link
Owner

image
It works fine on 3.10.2, it must be an issue with your machine

@TheFrenchGhosty
Copy link
Author

I have no idea what might be causing this honestly. I really don't know.

@Emersont1
Copy link
Owner

I've pushed v1.2.1, this should give more detail on the error. If you could post it, censoring any secret data, that would be smashing, and hopefully I can resolve this

@TheFrenchGhosty
Copy link
Author

Error: success key is not true
Will print the response text (Please be careful as this may contain personal data or allow others to login to your account):
{"recaptcha_url":"https:\/\/itch.io\/captcha","success":false,"recaptcha_needed":true}
Traceback (most recent call last):
  File "/home/user/.local/bin/itch-download", line 8, in <module>
    sys.exit(main())
  File "/home/user/.local/lib/python3.10/site-packages/itchiodl/downloader/__main__.py", line 25, in main
    l = itchiodl.LoginAPI(user, password)
  File "/home/user/.local/lib/python3.10/site-packages/itchiodl/login.py", line 46, in LoginAPI
    raise RuntimeError
RuntimeError

Here's the issue, there's a captcha.

@Emersont1
Copy link
Owner

Are you running this on a domestic IP or a datacenter IP?

@TheFrenchGhosty
Copy link
Author

Datacenter IP

@Emersont1
Copy link
Owner

That'd be it then

@TheFrenchGhosty
Copy link
Author

So I guess it's a non-issue, and I should just stick to API key.

Might be nice to have itch-load-bundle support API key too

@Emersont1
Copy link
Owner

The Web scraper needs to be run over HTTP, so you'll have to run that on your PC

@TheFrenchGhosty
Copy link
Author

Got it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants