Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the aabb config option not scale the bundle so i have easier control of scale #82

Closed
ethereumdegen opened this issue May 19, 2024 · 4 comments

Comments

@ethereumdegen
Copy link

What problem does this solve or what need does it fill?

Make the aabb config option not scale the bundle so i have easier control of scale

@ethereumdegen
Copy link
Author

I believe the fix is to remove the last element from this equation

// ---Y_POSITIONS---
position_field_offset.y = texture2d_offset(y_texture, position_field_offset.).r * aabb.vect.y;

@EmiOnGit
Copy link
Owner

Is this not relevant anymore? @ethereumdegen

@ethereumdegen
Copy link
Author

ethereumdegen commented May 20, 2024

I tried that simple fix and it didnt pan out. I think it is OK to keep it as is for now . There are bigger fish to fry. I actually got this crate working with my setup (besides the crash race cond issue i posted #81 ) check this out

image

@EmiOnGit
Copy link
Owner

Well first of, this looks great! :)
The debug aabb is from the grass entity? I actually don't think that the crate should use the aabb at all for scaling purposes.
A Plane should be way better to describe the area since the height of the blades is handled by the height component anyway. Sadly, there is no finite plane in bevy (was added recently). I'll swap out the aabb in the new mayor Bevy upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants