Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinates and dimensions of addCube are switched #7

Closed
filipejsbrandao opened this issue Jul 29, 2021 · 4 comments
Closed

Coordinates and dimensions of addCube are switched #7

filipejsbrandao opened this issue Jul 29, 2021 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@filipejsbrandao
Copy link
Contributor

I started playing with hackuble this morning. I read through the Geometry code to understand the inputs of Cube and addCube functions in C#. I would expect that the first three inputs (named x,y,z) would be the position coordinates of the cube (perhaps the center although this is not specified in the code). And the inputs named width, depth, height to be the dimensions of the cube. Yet the reverse is happening. Having a look at the JS code that adds the sphere to the context it is clear that x,y,z are being used to create the geometry and width, depth, height as the position coordinates.

@pm-Architect
Copy link
Collaborator

Hi @filipejsbrandao
Great to see that you've already started playing around with hackuble!
The C# functions you're referring to are supposed to be direct reflections of Three.js functions in C#. Since this was a hackathon project, to begin with, we only added a few such functions, which might also be a bit buggy.
Thanks for pointing this out! We'll remember to fix this when we do a pass on the three.js functions.

@filipejsbrandao
Copy link
Contributor Author

Hello @pm-Architect
It is very good work for a hackaton, congrats to you and the rest of the team!
I've also experimented adding one more input type, a boolean input. It seems fairly straightforward to expand the functionality of Hackuble. A feature I would love to see, but don't have the faintest idea where to start, is the ability to click on geometry in the viewport to edit the inputs. Best

@pm-Architect
Copy link
Collaborator

Thanks! Glad you like it!
That's an interesting idea. We're currently working on creating a version of hackuble for desktop, which will feature a visual scripting environment ;-)

@EmilPoulsen EmilPoulsen added bug Something isn't working good first issue Good for newcomers labels Aug 11, 2021
@EmilPoulsen
Copy link
Owner

Thanks for the comment @filipejsbrandao. Don't be shy if you want to submit a pull request with a bug fix! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants