Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner version, rename slug #116

Open
6 of 9 tasks
jdevalk opened this issue Jan 19, 2024 · 3 comments
Open
6 of 9 tasks

Cleaner version, rename slug #116

jdevalk opened this issue Jan 19, 2024 · 3 comments
Assignees

Comments

@jdevalk
Copy link
Member

jdevalk commented Jan 19, 2024

I want to make the next version of this plugin, and resubmit it to the .org repository as comment-hacks.

  1. Branch off a branch to use in step 7.
  2. Remove all mentions of Yoast in PHP and CSS class names.
  3. Remove all the deprecations.
  4. Consider simpler auto-loader.
  5. Change namespace to something simpler.
  6. Build zip, submit to .org repository.
  7. Create the translations@emilia.capital email alias

After approval of the plugin on .org:

  1. Once approved, email PatchStack team to update the VDP (see link in the Security.md file).
  2. Build a version of the original yoast-comment-hacks plugin that tries to update itself to the new comment-hacks version.
@jdevalk jdevalk self-assigned this Jan 19, 2024
@aristath
Copy link
Member

aristath commented Jan 22, 2024

  • Created a develop branch, to be used for the new plugin
  • Branched off that in the cleanup branch
  • Created PR Cleanup - prep for new plugin #117 which takes care of removing references to Yoast, and removing deprecations.

Once #117 gets merged to the develop branch, we can continue with the rest of the items on the list - I didn't want to include all changes in the same PR in order to better separate the tasks 👍

@aristath
Copy link
Member

Autoloader tweaks in #118

@jdevalk
Copy link
Member Author

jdevalk commented Jan 23, 2024

Emailed the plugins team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants