Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable javascript error tracking #37

Closed
santoshyadavdev opened this issue Mar 23, 2022 · 6 comments
Closed

feat: enable javascript error tracking #37

santoshyadavdev opened this issue Mar 23, 2022 · 6 comments
Labels
bug Something isn't working released on @1.x released on @2.x released tracker About @ngx-matomo/tracker

Comments

@santoshyadavdev
Copy link

Matomo enables javascript error tracking

link below:

https://matomo.org/faq/how-to/how-do-i-enable-basic-javascript-error-tracking-and-reporting-in-matomo-browser-console-error-messages/

we need to add

_paq.push(['enableJSErrorTracking']);

let me know I am happy to contribute if this is accepted.
@EmmanuelRoux
Copy link
Owner

Hi @santoshyadavdev
Of course you can provide a PR!
Thank you

@EmmanuelRoux EmmanuelRoux added tracker About @ngx-matomo/tracker bug Something isn't working labels Mar 23, 2022
@traycold traycold mentioned this issue Mar 23, 2022
Closed
@EmmanuelRoux
Copy link
Owner

Hi @santoshyadavdev

Just in case you would like to provide a PR, I think there are two main points to deal with:

  • The first is to add new method to MatomoTracker api
  • The second (optional but appreciated!) is to provide a way to let user configure this behavior with a new configuration option

@EmmanuelRoux
Copy link
Owner

Hi @santoshyadavdev,
Just to have an idea on planning, do you think you will be able to propose a PR (even partial) for this issue?
Thank you!

github-actions bot pushed a commit that referenced this issue May 3, 2022
@EmmanuelRoux
chore(release): 2.4.2
51df448 
## [2.4.2](v2.4.1...v2.4.2) (2022-05-03)

### Bug Fixes

* **tracker:** add enableJSErrorTracking as configuration option ([1586d78](1586d78))
* **tracker:** add enableJSErrorTracking tracker method ([68136d5](68136d5)), closes [#37](#37)
@EmmanuelRoux
Copy link
Owner

🎉 This issue has been resolved in version 2.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

EmmanuelRoux added a commit that referenced this issue May 3, 2022
@EmmanuelRoux
fix(tracker): add enableJSErrorTracking tracker method
234ea16 
cherry-picked from 68136d5
fixes #37
github-actions bot pushed a commit that referenced this issue May 3, 2022
@EmmanuelRoux
chore(release): 1.3.6
a66af0d 
## [1.3.6](v1.3.5...v1.3.6) (2022-05-03)

### Bug Fixes

* **tracker:** add enableJSErrorTracking as configuration option ([9a10e88](9a10e88))
* **tracker:** add enableJSErrorTracking tracker method ([234ea16](234ea16)), closes [#37](#37)
@EmmanuelRoux
Copy link
Owner

🎉 This issue has been resolved in version 1.3.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@EmmanuelRoux
Copy link
Owner

🎉 This issue has been resolved in version 2.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released on @1.x released on @2.x released tracker About @ngx-matomo/tracker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EmmanuelRoux @santoshyadavdev