Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Exclude list..." is missing for Lua Inlay Hints #393

Open
pouwelsjochem opened this issue Dec 19, 2020 · 1 comment
Open

"Exclude list..." is missing for Lua Inlay Hints #393

pouwelsjochem opened this issue Dec 19, 2020 · 1 comment

Comments

@pouwelsjochem
Copy link
Contributor

Environment(环境)

name version
IDEA version 2020.3
EmmyLua version 1.3.5
OS MacOS 10.15.7

What are the steps to reproduce this issue?(重现步骤?)

Open Preferences -> Editor -> Inlay Hints

What happens?(出现什么问题?)

The Groovy, Java and Kotlin options have an "Exclude list..."
For Lua it is missing.

What were you expecting to happen?(期望?)

"Exclude list..." to appear so Inlay Hints are even more useful.

Any other comments?(其它说明)

Inlay Hints are a pretty useful feature in Intellij. But having no way to make exceptions makes it less desirable, it makes a lot of the code very bulky. In some situations it is just very clear what the parameters are:

require(modname: "module") doesn't have to say you passed a 'modname' since everyone knows what require() does.
math.max(x: 1, 10) hints '1' is 'x', which only make it less understandable
string.lower(s: "Test") the 's' hint here is pretty obvious as well

These are just some examples for the default Lua libraries, the "Exclude list..." could also allow enable/disable inlay hints for your own code.

e.g. it would be great code like worldHelper:getObjectByName(_objectName: "myObjectName") wouldn't give any hints about the parameter being a _objectUID

@pouwelsjochem
Copy link
Contributor Author

I've adding initial support for the Exclude List myself, could be improved later on when necessary but it already adds the ability to disable Inlay Params in a lot of occasions. See #399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant