Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject project #377

Closed
Tracked by #327
gjermundgaraba opened this issue Dec 9, 2022 · 2 comments · Fixed by #395
Closed
Tracked by #327

Reject project #377

gjermundgaraba opened this issue Dec 9, 2022 · 2 comments · Fixed by #395
Assignees
@maheshKRex
Labels
C:x/plasticcredit Plastic credit component

Comments

@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Dec 9, 2022 •
edited
Loading

New tx message to reject a project.

  • Only an admin from the issuer of the credit class referenced in the project is allowed to reject a project (See how this was done for Approve Project)
  • It should not be possible to reject an already approved project
  • It should not be possible to reject an already rejected project
  • It should not be possible to issue credits for a project that has been rejected

Extra: Check and test that you can only approve projects that are in the NEW state (i.e. that you can approve a project that is already approved or rejected)

Tip: look at the code done in #354.
@gjermundgaraba gjermundgaraba mentioned this issue Dec 9, 2022
Closed
@gjermundgaraba gjermundgaraba self-assigned this Dec 9, 2022
@gjermundgaraba gjermundgaraba added the C:x/plasticcredit Plastic credit component label Dec 9, 2022
@gjermundgaraba gjermundgaraba added this to the V1 milestone Dec 9, 2022
@maheshKRex
Copy link
Contributor

@gjermundgaraba should we store a reason to reject from admin?

@gjermundgaraba
Copy link
Contributor Author

Not for now.

@maheshKRex maheshKRex linked a pull request Dec 16, 2022 that will close this issue
reject project implementation, tests, validations, updates to issuer tests #395
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maheshKRex maheshKRex

Labels
C:x/plasticcredit Plastic credit component
Projects
None yet
Milestone
No milestone
2 participants
@gjermundgaraba @maheshKRex