Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning modal for debug wallets #770

Merged
merged 2 commits into from Feb 14, 2020

Conversation

v-almonacid
Copy link
Contributor

@v-almonacid v-almonacid commented Feb 13, 2020

Modal is added right after a wallet is selected, within the TxHistory screen. Accepting the modal sends user to WalletSelectionScreen.

Edit: modal is also added in Delegation dashboard. In both cases it's triggered if wallet corresponds to any of the two default wallets used for debugging.

Copy link
Contributor

@nicarq nicarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

src/crypto/wallet.js Outdated Show resolved Hide resolved
src/crypto/wallet.js Outdated Show resolved Hide resolved
@nicarq nicarq merged commit 6a37478 into shelley Feb 14, 2020
@nicarq nicarq deleted the v_almonacid/ch2689/warn-users-with-flawed-wallets branch February 14, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants