Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShowDualPointList #57

Closed
9 tasks done
Tracked by #61
ddfridley opened this issue Nov 3, 2023 · 3 comments · Fixed by #94
Closed
9 tasks done
Tracked by #61

ShowDualPointList #57

ddfridley opened this issue Nov 3, 2023 · 3 comments · Fixed by #94
Assignees

Comments

@ddfridley
Copy link
Contributor

ddfridley commented Nov 3, 2023

image
Figma

<ShowDualPointList className={} style={}
    leftPoints= []  // can be a point, or a pointGroup
    leftHeader= ""
    rightPoints=[] // can be a point, or a pointGroup
    rightHeader=""
    vState="collapsed"||"expanded"
/>
  • should render as 2 columns within width of the parent
  • each point should be rendered using the Point Group Component #35 and applying the appropriate vState, plus a className to apply the backgroundColor
  • Use the Button component Button components #43
  • Create stories
  • story for case where props are undefined
  • story for case where lists are empty
  • story data should include some pointGroups
  • stories for the 2 different vState's
  • story with a mobile width parent

Note we are going to add a collapsed state to the Point component, so this component can render PointComponents and pass in a collapsed vState to show the data.

@ddfridley ddfridley mentioned this issue Nov 9, 2023
7 tasks
This was referenced Dec 1, 2023
@ddfridley
Copy link
Contributor Author

added to requirements above to use the Point component

@ddfridley
Copy link
Contributor Author

changed requirement to use the PointGroup component - which can render single points.

@ldgze
Copy link
Contributor

ldgze commented Mar 18, 2024

May I take on this task? At the moment, I'm unable to assign this issue to myself. @ddfridley

@ddfridley ddfridley linked a pull request Apr 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants